Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sum bux #9690

Merged
merged 4 commits into from
Jan 31, 2021
Merged

Fix sum bux #9690

merged 4 commits into from
Jan 31, 2021

Conversation

Megamouse
Copy link
Contributor

  • Simplify compile threads
  • Minor optimization for check_only ppu_initialize
  • Fix stop exit of check_only ppu_initialize
  • Prevent minor race in Progress Dialog Server

@Megamouse Megamouse added Bugfix Optimization Optimizes existing code labels Jan 30, 2021
elad335
elad335 reviewed Jan 31, 2021
View reviewed changes
rpcs3/Emu/System.cpp
ftotal = ftotal_new;
fdone = fdone_new;
ptotal = ptotal_new;
pdone = pdone_new;
Copy link
Contributor

@elad335 elad335 Jan 31, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a race but then again there's nothing wrong here as well, but its a good practice to avoid redundent atomic reads.

@Nekotekina Nekotekina merged commit 31cdd7b into RPCS3:master Jan 31, 2021
@Megamouse Megamouse deleted the progressssss branch January 31, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elad335 elad335 elad335 left review comments

@Nekotekina Nekotekina Awaiting requested review from Nekotekina

Assignees
No one assigned
Labels
Bugfix Optimization Optimizes existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Megamouse @elad335 @Nekotekina